Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove lastPendingTimestamp as required field in status #22

Merged
merged 1 commit into from
May 20, 2020
Merged

remove lastPendingTimestamp as required field in status #22

merged 1 commit into from
May 20, 2020

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented May 20, 2020 •
edited
Loading

What this PR does / why we need it:
fix for certificate crd validation. The field lastPendingTimestamp in the status is not required. This prevents creating new certificates.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

validation: remove lastPendingTimestamp as required field in status

@MartinWeindel MartinWeindel requested review from a team as code owners May 20, 2020 07:17
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2020
timuthy
timuthy approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you for taking care!

@ghost ghost added the reviewed/lgtm Has approval for merging label May 20, 2020
@timuthy timuthy merged commit 3877160 into master May 20, 2020
@timuthy
Copy link
Member

timuthy commented May 20, 2020

@MartinWeindel can you cherry-pick on branch release-v1.6 and build a hotfix?

MartinWeindel pushed a commit that referenced this pull request May 20, 2020
@timuthy @MartinWeindel
Merge pull request #22 from gardener/lastpending-notrequired
54f96cd 
remove lastPendingTimestamp as required field in status
MartinWeindel added a commit that referenced this pull request May 20, 2020
@MartinWeindel
```improvement user #22 @MartinWeindel
bc755e5 
validation: remove lastPendingTimestamp as required field in status
```
@MartinWeindel MartinWeindel mentioned this pull request May 22, 2020
Closed
@rfranzke rfranzke deleted the lastpending-notrequired branch August 5, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @timuthy @gardener-robot-ci-1 @gardener-robot-ci-3