Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deletion of source DNSEntries has to wait for complete deletion of target entries #407

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Deletion of source DNSEntries has to wait for complete deletion of target entries #407

merged 2 commits into from
Dec 17, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Dec 16, 2024 •
edited
Loading

What this PR does / why we need it:
The deletion of source DNSEntries has to wait for complete deletion of target entries. Otherwise a following deletion of a source DNS provider may be performed too early and the credentials may already gone for finishing the deletion of the DNS records.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Deletion of source DNSEntries must wait for completed deletion of target entries.

@MartinWeindel MartinWeindel requested a review from a team as a code owner December 16, 2024 13:08
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 16, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2024
@MartinWeindel
Copy link
Member Author

/cc @marc1404

marc1404
marc1404 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

/lgtm

pkg/dns/source/reconciler.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
@MartinWeindel @marc1404
wrap error
64a8060 
Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Dec 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
marc1404
marc1404 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/second-opinion Needs second review by someone else labels Dec 17, 2024
@MartinWeindel MartinWeindel merged commit 0b8df81 into master Dec 17, 2024
12 checks passed
@MartinWeindel MartinWeindel deleted the fix/dnsentry-source-wait-for-deletion branch December 17, 2024 12:09
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot