Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creating certificates with a given csr referencing a ca issuer #234

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

RaphaelVogel
Copy link
Member

@RaphaelVogel RaphaelVogel commented Jul 26, 2024

How to categorize this PR?
/kind bug

What this PR does / why we need it:
Creating a certificate referencing a ca issuer with a given csr creates a nil pointer exception.
Example:

apiVersion: cert.gardener.cloud/v1alpha1
kind: Certificate
metadata:
  name: cert-csr
  namespace: default
spec:
  csr: ......
  issuerRef:
    name: some-ca-issuer

Release note:

Creating certificates with a given csr referencing a ca issuer do not throw a nil pointer exception anymore 

@gardener-prow gardener-prow bot requested a review from MartinWeindel July 26, 2024 07:54
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2024
@RaphaelVogel RaphaelVogel removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 26, 2024
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We should introduce integration tests as a follow-up

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
Copy link

gardener-prow bot commented Jul 26, 2024

LGTM label has been added.

Git tree hash: 6786ea95723e51c15157639ae707d206c4874ef9

Copy link

gardener-prow bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinWeindel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2024
@MartinWeindel
Copy link
Member

/kind enhancement

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jul 26, 2024
@gardener-prow gardener-prow bot merged commit f7c8900 into master Jul 26, 2024
9 checks passed
@MartinWeindel MartinWeindel deleted the ca-issuer branch August 19, 2024 13:47
@marc1404 marc1404 mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants