Avoids panics when VM type isn't found during scale from zero #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cluster autoscaler was trying to fetch VM details for AWS VMs instead of required Azure VMs for MCM (OOT) provider Azure. This lead to panics. Now, it fetches the details from the correct provider VM map. - This PR also improves error handling in such scenarios to not panic.
|
/invite @AxiomSamarth @ialidzhikov |
prashanth26
commented
May 11, 2021
| @@ -681,8 +690,10 @@ func (m *McmManager) GetMachineDeploymentNodeTemplate(machinedeployment *Machine | |||
| if err != nil { | |||
| return nil, fmt.Errorf("Unable to convert from %s to %s for %s, Error: %v", kindMachineClass, providerAzure, machinedeployment.Name, err) | |||
| } | |||
|
|
|||
| azureInstance := aws.InstanceTypes[providerSpec.Properties.HardwareProfile.VMSize] | |||
| azureInstance, exists := azure.InstanceTypes[providerSpec.Properties.HardwareProfile.VMSize] | |||
There was a problem hiding this comment.
The key change causing the panic is here, where it was fetching AWS details for Azure VMs.
|
@prashanth26 , can you please file a cherry-pick and cut a |
Yes, on it. Thanks. |
|
Also tested this change locally. Scale from zero seems to work as before/expected now. No more panics. |
AxiomSamarth
approved these changes
May 11, 2021
ialidzhikov
pushed a commit
to ialidzhikov/autoscaler
that referenced
this pull request
May 23, 2021
…er#77) - Cluster autoscaler was trying to fetch VM details for AWS VMs instead of required Azure VMs for MCM (OOT) provider Azure. This lead to panics. Now, it fetches the details from the correct provider VM map. - This PR also improves error handling in such scenarios to not panic.
ialidzhikov
pushed a commit
to ialidzhikov/autoscaler
that referenced
this pull request
Jul 14, 2021
…er#77) - Cluster autoscaler was trying to fetch VM details for AWS VMs instead of required Azure VMs for MCM (OOT) provider Azure. This lead to panics. Now, it fetches the details from the correct provider VM map. - This PR also improves error handling in such scenarios to not panic.
prashanth26
added a commit
that referenced
this pull request
Jul 14, 2021
) - Cluster autoscaler was trying to fetch VM details for AWS VMs instead of required Azure VMs for MCM (OOT) provider Azure. This lead to panics. Now, it fetches the details from the correct provider VM map. - This PR also improves error handling in such scenarios to not panic. Co-authored-by: Prashanth <prashanth@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #76
Special notes for your reviewer:
Release note: