Ignore the node-group with maxSize set to 0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanth26
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR ignores the node-group with maxSize set to zero.
Earlier autoscaler could not scale-up the healthy worker-pool if there exists another worker-pool with min=max=0.
NodeTemplateInfois not implemented for all providers, it used to fail for providers other than AWS and Azure. This failure blocks the scale-up for other healthy worker-pools as well, due to the nature of CA.With this change, we simply ignore the worker-pools which have maxSize set to 0.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: