Use zone-info while scaling-up the node-group from zero #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikdr
commented
May 3, 2020
| @@ -946,6 +946,7 @@ type AzureVirtualMachineProperties struct { | |||
| OsProfile AzureOSProfile | |||
| NetworkProfile AzureNetworkProfile | |||
| AvailabilitySet AzureSubResource | |||
| Zone *int | |||
There was a problem hiding this comment.
This is a workaround for now.
We should ideally re-vendor the MCM, but it seems challenging due to recently updated Azure-dependencies in MCM, I would prefer to do it separately.
hardikdr
commented
May 3, 2020
| @@ -424,15 +428,19 @@ func (m *McmManager) GetMachineDeploymentNodeTemplate(machinedeployment *Machine | |||
| GPU: azureInstance.GPU, | |||
| } | |||
| region = mc.Spec.Location | |||
| if mc.Spec.Properties.Zone != nil { | |||
| // Do not re-use the zone before re-vendoring mcm. | |||
| zone = mc.Spec.Location + strconv.Itoa(*mc.Spec.Properties.Zone) | |||
There was a problem hiding this comment.
Yet to test this change for Azure.
There was a problem hiding this comment.
I tested this PR with Azure now, works well.
prashanth26
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR uses the zone-information for scaling the node-groups from zero.
Which issue(s) this PR fixes:
Fixes #34
Special notes for your reviewer:
Release note: