Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM:<carry> Add configurable delay for pod age before considering for scale-up #33

Merged
merged 4 commits into from
Apr 9, 2020
Merged

UPSTREAM:<carry> Add configurable delay for pod age before considering for scale-up #33

merged 4 commits into from
Apr 9, 2020

Conversation

hardikdr
Copy link
Member

@hardikdr hardikdr commented Apr 1, 2020

What this PR does / why we need it: Introduces the scale-up delay time. It is seen that pods may stay in unschedulable state while the corresponding PVC could be bound to another node. With scale-up delay time, CA can be configured to wait for sometime before actual scale-up happens.

Which issue(s) this PR fixes:
Fixes #28

Special notes for your reviewer:

Release note:

Add configurable delay for pod age before considering for scale-up

hercynium added 4 commits April 1, 2020 13:16
@hercynium @hardikdr
Add configurable delay for pod age before considering for scale-up
fe3ce6b 
  - This is intended to address the issue described in kubernetes#923
  - the delay is configurable via a CLI option
  - in production (on AWS) we set this to a value of 2m
  - the delay could possibly be set as low as 30s and still be effective depending on your workload and environment
  - the default of 0 for the CLI option results in no change to the CA's behavior from defaults.

Change-Id: I7e3f36bb48641faaf8a392cca01a12b07fb0ee35
@hercynium @hardikdr
Fixing nits: renamed newPodScaleUpBuffer -> newPodScaleUpDelay, delet…
06ef40c 
…ed redundant comment

Change-Id: I7969194d8e07e2fb34029d0d7990341c891d0623
@hercynium @hardikdr
Added info about new --new-pod-scale-up-delay param to FAQ
d9d589a 
Change-Id: I9e6e56cca1f807b4c1d729dede590b1d10c0f56c
@hercynium @hardikdr
Renamed one more variable for consistency
e119098 
Change-Id: Idf42fd58089a1e75f3291ab7cc583735c68735f2
@hardikdr hardikdr requested a review from prashanth26 as a code owner April 1, 2020 07:57
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2020
@hardikdr
Copy link
Member Author

hardikdr commented Apr 1, 2020

cc @dtsvetkovsap

@hardikdr hardikdr merged commit d7da9d7 into gardener:machine-controller-manager Apr 9, 2020
@hardikdr hardikdr deleted the cherry-pick-1245 branch April 9, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster autoscaler is triggered during provisioning of PVC
6 participants
@hardikdr @CLAassistant @prashanth26 @gardener-robot-ci-2 @gardener-robot-ci-3 @hercynium