Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repo compliant #297

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Make repo compliant #297

merged 1 commit into from
Feb 22, 2024

Conversation

RaphaelVogel
Copy link
Member

What this PR does / why we need it:

  • Updated CONTRIBUTING.md file
  • Created/Updated LICENSE file
  • Created/Updated .reuse/dep5 file
  • Created/Updated LICENSES folder
  • Added badge for reuse compliance in README.md file and registered repo with REUSE API
  • License/Copyright header replacement for 'non-go' files
    • .ci/test
    • .ci/build
    • .ci/check
  • License/Copyright header replacement for 'go' files
    • cluster-autoscaler/cloudprovider/mcm/machine_client_builder.go
    • cluster-autoscaler/cloudprovider/mcm/test_utils.go
    • cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider_test.go
    • cluster-autoscaler/cloudprovider/mcm/fakeclient/client.go

@RaphaelVogel RaphaelVogel added the area/ipcei IPCEI (Important Project of Common European Interest) label Feb 21, 2024
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 21, 2024
rishabh-11
rishabh-11 approved these changes Feb 22, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 22, 2024
@rishabh-11 rishabh-11 self-assigned this Feb 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2024
@rishabh-11 rishabh-11 merged commit 5d7603b into gardener:machine-controller-manager-provider Feb 22, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 22, 2024
@RaphaelVogel
Copy link
Member Author

@rishabh-11 some additional info.
To keep this repository compliant, CODEOWNERS must maintain their third party dependencies in the vendor folder using .reuse/dep5 file. To prevent constant maintenance effort, it is highly recommended to remove the vendor folder. In this case no third party dependencies of the vendor folder must be maintained anymore!

@rishabh-11
Copy link

rishabh-11 commented Feb 22, 2024 •
edited
Loading

@RaphaelVogel the upstream has not removed the vendor directory yet. It will cause problems for us while syncing the fork if we remove the vendor in our fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@rishabh-11 rishabh-11

Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaphaelVogel @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot