Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back VPA pipeline, but with render_pipeline: false #289

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Bring back VPA pipeline, but with render_pipeline: false #289

merged 1 commit into from
Jan 18, 2024

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Jan 17, 2024

What this PR does / why we need it:
In order to get rid of the pipeline in our CI, we need to bring back the definition, but introduce the property render_pipeline: false. Otherwise the rendering job will fail and the removed pipeline will never be cleaned up.

Release note:

NONE

@gardener-robot gardener-robot added the needs/review Needs review label Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2024
rishabh-11
rishabh-11 approved these changes Jan 18, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 18, 2024
@rishabh-11 rishabh-11 merged commit 914d134 into gardener:machine-controller-manager-provider Jan 18, 2024
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voelzmo @rishabh-11 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot