Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #269

Merged
merged 2 commits into from
Dec 11, 2023
Merged

switch GCR -> Artifact-Registry #269

merged 2 commits into from
Dec 11, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 7, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk
cleanup: remove obsolete/redundant attributes
94ed5d7
@ccwienk
switch GCR -> Artifact-Registry
aaffaa2 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gc
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 7, 2023
@ccwienk ccwienk requested a review from voelzmo December 8, 2023 10:44
@gardener-robot
Copy link

@unmarshall, @himanshu-kun, @voelzmo, @rishabh-11 You have pull request review open invite, please check

@voelzmo
Copy link
Member

voelzmo commented Dec 11, 2023

/lgtm Thanks!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 11, 2023
@ccwienk
Copy link
Member Author

ccwienk commented Dec 11, 2023

merging according to @voelzmo 's /lgtm comment

@ccwienk ccwienk merged commit 5289808 into machine-controller-manager-provider Dec 11, 2023
@ccwienk ccwienk deleted the gcr-to-ar branch December 11, 2023 11:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccwienk @gardener-robot @voelzmo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3