Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up last imports of k8s.io/klog in favor of k8s.io/klog/v2 #231

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Clean up last imports of k8s.io/klog in favor of k8s.io/klog/v2 #231

merged 1 commit into from
Jun 23, 2023

Conversation

ialidzhikov
Copy link
Member

/kind cleanup

What this PR does / why we need it:
Similar to gardener/machine-controller-manager-provider-openstack#47.

Which issue(s) this PR fixes:
See gardener/machine-controller-manager-provider-openstack#46

Special notes for your reviewer:
N/A

Release note:

`k8s.io/klog` is no longer imported by the cluster-autoscaler. `k8s.io/klog/v2` is used instead in a consistent manner.

@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 23, 2023
rishabh-11
rishabh-11 approved these changes Jun 23, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 23, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 23, 2023
@rishabh-11 rishabh-11 merged commit 12d5585 into gardener:machine-controller-manager-provider Jun 23, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 23, 2023
@rishabh-11 rishabh-11 self-assigned this Jun 23, 2023
@ialidzhikov ialidzhikov deleted the cleanup/klog branch June 23, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@rishabh-11 rishabh-11

Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @rishabh-11 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot