Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix targeted scale-in logic #215

Merged
merged 26 commits into from
Aug 17, 2023
Merged

Fix targeted scale-in logic #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3d0289d
reset priority of machines with no deletion taint to 3
May 16, 2023
c012da3
run hack/update-gofmt.sh
May 16, 2023
ba1459d
address review comments and refactor DeleteMachines method
May 18, 2023
acc7e7b
address review comments part 2
May 22, 2023
2748ca3
address review comments part 3
May 22, 2023
fda764e
remove time.Sleep from mcm_manager.go
May 25, 2023
dcfc137
added timeouts to mcmManager struct for testing
Jul 10, 2023
9af44fe
initial changes for testing framework
Jul 10, 2023
8e75b54
minor refactoring of mcm cloudprovider implementation
Jul 18, 2023
81bd4ce
refactor fakingOptions in fake client
Jul 18, 2023
a2c4ff3
introduce unit tests for DeleteNodes method
Jul 18, 2023
902f68d
vendor changes
Jul 18, 2023
26323e9
resolve linting errors
Jul 18, 2023
c2feb6c
remove race conditions
Jul 19, 2023
6d056d7
remove race conditions part-2
Jul 19, 2023
7824ca9
address review comments part-1
Jul 20, 2023
9b7f40d
remove deadline for cache get/list calls
Jul 20, 2023
2344ef0
update for-go-proj.sh to run only mcm tests in cloudprovider
Jul 20, 2023
549206c
update doc string
Jul 27, 2023
e3cfccc
address review comments
Aug 8, 2023
9998790
address review comments part-2
Aug 8, 2023
a80deb0
move reset priority logic to refresh method
Aug 14, 2023
a13a0ba
address review comments part-3
Aug 14, 2023
2c9cc81
address review comments part-4
Aug 16, 2023
235d739
address review comments part-5
Aug 16, 2023
1ae3746
return collective error for priority reset of machines
Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cluster-autoscaler/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,10 @@ start:
@GO111MODULE=on go run main.go \
--kubeconfig=$(TARGET_KUBECONFIG) \
--cloud-provider=mcm \
--nodes=1:2:$(MACHINE_DEPLOYMENT_ZONE_1) \
--nodes=0:1:$(MACHINE_DEPLOYMENT_ZONE_2) \
--nodes=0:1:$(MACHINE_DEPLOYMENT_ZONE_3) \
--nodes=0:2:$(MACHINE_DEPLOYMENT_1_ZONE_1) \
--nodes=1:2:$(MACHINE_DEPLOYMENT_2_ZONE_1) \
--nodes=0:1:$(MACHINE_DEPLOYMENT_2_ZONE_2) \
--nodes=0:1:$(MACHINE_DEPLOYMENT_2_ZONE_3) \
--skip-nodes-with-system-pods=false \
--skip-nodes-with-local-storage=false \
--scale-down-delay-after-add=10s \
Expand Down Expand Up @@ -147,7 +148,7 @@ download-kubeconfigs:
read SHOOT; \
echo "enter cluster provider(gcp|aws|azure|vsphere|openstack|alicloud|metal|equinix-metal)"; \
read PROVIDER; \
echo "enter zone with zero nodes where the PV needs to be created to perform test"; \
echo "enter zone with zero nodes in worker pool \"three-zones\" where the PV needs to be created to perform test"; \
read ZONE; \
. ./hack/local_setup.sh --SEED $$SEED --SHOOT $$SHOOT --PROJECT $$PROJECT; \
echo "###############################################" ; \
Expand Down
Loading