-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of generic scale from zero #102
implementation of generic scale from zero #102
Conversation
The changes are tested with the below steps on AWS, OpenStack
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
- However, improve the release notes
- to provide more details on how to make use of it as end user
- As well about deprecation of current scale from zero logic.
- Finally adding some tests will help
/lgtm otherwise.
/needs second-opinion
@himanshu-kun
@prashanth26 Label needs/@himanshu-kun does not exist. |
@prashanth26 Sure, Prashanth. I will incorporate those suggestions. |
681ba23
to
1a9fd63
Compare
@himanshu-kun, @hardikdr You have pull request review open invite, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good , I will test myself once as well. Adding a unit test would be good.
The machine catalogue is updated with the new data types. However, new files are created in the Tested for backward compatibility. Works fine. The CRD & API changes from the new MCM release should be vendored in this PR. Post which the CA build will go through successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the neat PR Samarth
As suggested I think we can change variable name MemoryMb
to Memory
as it could be misleading . You might have to generate the catalogues again in that case.
Also as discussed by us of not fetching region
and zone
from expectedNodeAttributes
now, I think those changes will get incorporated in your next push. Just commenting as a reminder
e2d4da9
to
311d08d
Compare
311d08d
to
cb3b4ae
Compare
cb3b4ae
to
3ee48bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested and discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the neat changes, just some minor picks to improve error and logging messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…62298a730415c5d2ab72607ef6adadd6304d (e3de622)
935bf33
to
b6d684e
Compare
Merging the changes as decided. |
What this PR does / why we need it:
This PR implements the generic scale from zero logic.
Which issue(s) this PR fixes:
Fixes #27
Special notes for your reviewer:
Release note: