Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jl_reinit_foreign_type if available #5224

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Use jl_reinit_foreign_type if available #5224

merged 3 commits into from
Nov 28, 2022

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Nov 25, 2022 •
edited
Loading

This is part of the plan outlined in oscar-system/GAP.jl#846

@fingolfin fingolfin added topic: kernel topic: julia Julia GC integration and related matters labels Nov 25, 2022
This was referenced Nov 25, 2022
Merged
Merged
@fingolfin fingolfin force-pushed the mh/jl_reinit_foreign_type branch 3 times, most recently from 9b3e48f to 6919b0a Compare November 25, 2022 23:18
@fingolfin fingolfin changed the title WIP: experiment with using jl_reinit_foreign_type Use jl_reinit_foreign_type if available Nov 28, 2022
@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes backport-to-4.12 labels Nov 28, 2022
@fingolfin fingolfin marked this pull request as ready for review November 28, 2022 14:43
@fingolfin fingolfin force-pushed the mh/jl_reinit_foreign_type branch 2 times, most recently from 1b72a2a to 6c7b208 Compare November 28, 2022 14:45
@fingolfin fingolfin force-pushed the mh/jl_reinit_foreign_type branch from 6c7b208 to 6bf3057 Compare November 28, 2022 14:52
@fingolfin fingolfin enabled auto-merge (rebase) November 28, 2022 14:54
@fingolfin fingolfin mentioned this pull request Nov 28, 2022
Closed
8 tasks
ThomasBreuer
ThomasBreuer approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see, this looks good. (@ChrisJefferson will be able to give detailed comments.)

@fingolfin fingolfin merged commit 4c409bc into gap-system:master Nov 28, 2022
@fingolfin fingolfin deleted the mh/jl_reinit_foreign_type branch November 28, 2022 16:33
@fingolfin
Copy link
Member Author

Backported to stable-4.12 in fccdb8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
backport-to-4.12-DONE release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: julia Julia GC integration and related matters topic: kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ThomasBreuer