Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support class/character names in char. table Display #3626

Merged
merged 1 commit into from
Aug 27, 2019
Merged

support class/character names in char. table Display #3626

merged 1 commit into from
Aug 27, 2019

Conversation

ThomasBreuer
Copy link
Contributor

(This extension had been suggested in the GAP Forum by David Madore.)

  • Support components charnames and classnames
    in the second argument of CharacterTableDisplayDefault,
    in order to prescribe explicit row and column labels
    when displaying character tables with Display.

  • Added some tests for CharacterTableDisplayDefault.

@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 26, 2019
@ThomasBreuer
support class/character names in char. table Display
71ce712 
(This extension had been suggested in the GAP Forum by David Madore.)

- Support components `charnames` and `classnames`
  in the second argument of `CharacterTableDisplayDefault`.

- Added some tests for `CharacterTableDisplayDefault`.
@ThomasBreuer ThomasBreuer force-pushed the TB_Display_character_tables branch from ffb3fdb to 71ce712 Compare August 26, 2019 13:30
@ThomasBreuer ThomasBreuer merged commit 915e0ea into gap-system:master Aug 27, 2019
@ThomasBreuer ThomasBreuer deleted the TB_Display_character_tables branch August 27, 2019 08:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 84.41% when pulling 71ce712 on ThomasBreuer:TB_Display_character_tables into 0aee3f4 on gap-system:master.

@dimpase dimpase added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 4, 2020
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@hulpke hulpke hulpke approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ThomasBreuer @coveralls @fingolfin @hulpke @dimpase @olexandr-konovalov