Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgap: add basic APIs for working with matrices #3554

Merged
merged 2 commits into from
Jul 14, 2019
Merged

libgap: add basic APIs for working with matrices #3554

merged 2 commits into from
Jul 14, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Jul 11, 2019 •
edited
Loading

No description provided.

@fingolfin fingolfin added topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: libgap things related to libgap labels Jul 11, 2019
@coveralls
Copy link

coveralls commented Jul 11, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 84.298% when pulling 28c651e on fingolfin:mh/libgap-matrix into 0e29ceb on gap-system:master.

wilfwilson
wilfwilson reviewed Jul 12, 2019
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, although I'm not very familiar with libgap stuff.

@dimpase
Copy link
Member

dimpase commented Jul 12, 2019

having this in and using it in Sage will be great. @embray

@fingolfin
Copy link
Member Author

@dimpase well, then feel free to approve the PR so it can be merged ... :-)

@dimpase
Copy link
Member

dimpase commented Jul 12, 2019 via email

dimpase
dimpase approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, passes tests etc.

@fingolfin
Copy link
Member Author

@dimpase thanks for taking that extra step, but it really wouldn't have been necessary -- Travis already performed all these tests :-)

@ChrisJefferson ChrisJefferson merged commit a2d5dd9 into gap-system:master Jul 14, 2019
@fingolfin fingolfin deleted the mh/libgap-matrix branch July 14, 2019 23:32
@fingolfin fingolfin changed the title libgap: export some matrix APIs libgap: add basic APIs for working with matrices Aug 20, 2019
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson left review comments

@dimpase dimpase dimpase approved these changes

@ThomasBreuer ThomasBreuer Awaiting requested review from ThomasBreuer

@sebasguts sebasguts Awaiting requested review from sebasguts

@markuspf markuspf Awaiting requested review from markuspf

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fingolfin @coveralls @dimpase @wilfwilson @ChrisJefferson @olexandr-konovalov