Minor fixes that could go into 4.10 as well #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if source size is known and equals image size. This fixes gap-system#3431
The code assumed erraneously that the `IsomorphismFpGroup` of the radical factor is given on the free generators. That does not need to be the case (in which case weird errors happen). This fixes gap-system#3496.
|
@hulpke thanks. I've assigned this to 4.10.3 milestone - suggest to NOT to backport this to stable-4.10 until GAP 4.10.2 is out (expect to happen later this week). |
fingolfin
approved these changes
Jun 19, 2019
| @@ -878,6 +878,9 @@ local g, sq, hom; | |||
| g:=arg[1]; | |||
| sq:=CallFuncList(SQ,arg); | |||
| hom:=GroupHomomorphismByImages(g,sq.image,GeneratorsOfGroup(g),sq.imgs); | |||
| if HasSize(g) and Size(g)=Size(sq.image) then | |||
There was a problem hiding this comment.
Suggested change
| if HasSize(g) and Size(g)=Size(sq.image) then | |
| if HasSize(g) then |
| @@ -878,6 +878,9 @@ local g, sq, hom; | |||
| g:=arg[1]; | |||
| sq:=CallFuncList(SQ,arg); | |||
| hom:=GroupHomomorphismByImages(g,sq.image,GeneratorsOfGroup(g),sq.imgs); | |||
| if HasSize(g) and Size(g)=Size(sq.image) then | |||
| SetIsInjective(hom,true); | |||
There was a problem hiding this comment.
Suggested change
| SetIsInjective(hom,true); | |
| SetIsInjective(hom, Size(g)=Size(sq.image)); |
olexandr-konovalov
requested changes
Jun 19, 2019
|
@alex-konovalov You can remove your requested changes. |
olexandr-konovalov
approved these changes
Jun 24, 2019
|
@wilfwilson done! |
|
@hulpke I set release notes: not needed" label then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes for (an issue related to #3431) and #3496.
The circumstances of the errors are complicated and there were error messages, not wrong results, that I do not think they of help to describe them explicitly in an update description beyond summarizing them as "numerous errors")
Both issues are in 4.10 code.
Fixes #3496