-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP lib: add SetAsDomain #3460
Closed
Closed
WIP lib: add SetAsDomain #3460
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,3 +222,50 @@ InstallMethod( SubtractSet, | |
RemoveSet( set, obj ); | ||
od; | ||
end ); | ||
|
||
|
||
############################################################################# | ||
## | ||
InstallMethod(SetAsDomain, | ||
"for a set & collection", | ||
[IsSet and IsCollection], | ||
function(set) | ||
local copy, type, domain; | ||
copy := Immutable(set); | ||
type := NewType(FamilyObj(copy), | ||
IsSetAsDomain and IsAttributeStoringRep); | ||
return ObjectifyWithAttributes(rec(), type, | ||
GeneratorsOfDomain, copy, | ||
AsList, copy, | ||
AsSet, copy); | ||
end); | ||
|
||
# Provide family of objects `fam`. Then the resulting domain lives in the same | ||
# family as a domain created from a non-empty set of objects of `fam`. | ||
InstallOtherMethod(SetAsDomain, | ||
"for a family and an empty list", | ||
[IsFamily, IsEmpty and IsList], | ||
function(family, set) | ||
local copy, type; | ||
copy := Immutable([]); | ||
type := NewType(CollectionsFamily(family), | ||
IsSetAsDomain and IsAttributeStoringRep); | ||
return ObjectifyWithAttributes(rec(), type, | ||
GeneratorsOfDomain, copy, | ||
AsList, copy, | ||
AsSet, copy); | ||
end); | ||
|
||
InstallMethod(\in, | ||
"for an IsSetAsDomain", | ||
[IsObject, IsSetAsDomain], | ||
function(elm, set) | ||
return elm in AsList(set); | ||
end); | ||
|
||
InstallMethod(PrintObj, | ||
"for an IsSetAsDomain", | ||
[IsSetAsDomain], | ||
function( setAsDomain ) | ||
Print("SetAsDomain(", AsList(setAsDomain), ")"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't you need a different function for empty domains? |
||
end); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
IsSetAsDomain
is merely a synonym forIsDomain
; so now you really have installed a generic\in
method for arbitrary domains, which tries to useAsList
. That makes me a bit nervous, though I can't put my finger on it right now.