Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TemporaryGlobalVarName obsolete #3269

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Make TemporaryGlobalVarName obsolete #3269

merged 1 commit into from
Feb 8, 2019

Conversation

fingolfin
Copy link
Member

This is only used in two packages, SCSCP and anupq; I already have a
plan to get rid of it in anupq, and hope that SCSCP can also get rid of
it; alternatively, SCSCP could add its own copy of this function.

Resolves #2367

@fingolfin
Make TemporaryGlobalVarName obsolete
0be1a46 
This is only used in two packages, SCSCP and anupq; I already have a
plan to get rid of it in anupq, and hope that SCSCP can also get rid of
it; alternatively, SCSCP could add its own copy of this function.
@fingolfin fingolfin added topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 6, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+9.0e-05%) to 85.004% when pulling 0be1a46 on fingolfin:mh/TemporaryGlobalVarName into a70c068 on gap-system:master.

@fingolfin fingolfin merged commit 114e510 into gap-system:master Feb 8, 2019
@fingolfin fingolfin deleted the mh/TemporaryGlobalVarName branch February 8, 2019 18:47
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 25, 2019
Closed
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@olexandr-konovalov olexandr-konovalov Awaiting requested review from olexandr-konovalov

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

Deprecate TemporaryGlobalVarName
5 participants
@fingolfin @coveralls @ChrisJefferson @olexandr-konovalov @DominikBernhardt