Don't make package info records immutable #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes loading of float and JuliaInterface in master, as described in issue gap-system#2568, at least im regular GAP. For HPC-GAP, things remain unchanged for now.
Codecov Report
@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
- Coverage 75.34% 75.33% -0.01%
==========================================
Files 442 442
Lines 228957 228958 +1
==========================================
- Hits 172498 172496 -2
- Misses 56459 56462 +3
|
ChrisJefferson
approved these changes
Jul 2, 2018
olexandr-konovalov
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes loading of float and JuliaInterface in master, as described
in issue #2568, at least im regular GAP. For HPC-GAP, things remain
unchanged for now.
This does not yet fix that issue, as HPC-GAP remains affected. See that issue for ideas on how to properly solve the underlying concern.