kernel: don't include debug.h everywhere; and more #2536
Conversation
9039f24 to
163fac5
Compare
... by including it from system.h This ensures that debug flags are uniformly visible in the whole kernel.
Codecov Report
@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 74.4% 74.38% -0.02%
==========================================
Files 481 481
Lines 243488 243592 +104
==========================================
+ Hits 181157 181200 +43
- Misses 62331 62392 +61
|
| // do not print a message if we found one already on the current line | ||
| if (STATE(NrErrLine) == 0) { | ||
|
|
There was a problem hiding this comment.
Why do this?
Also, other people are (as I understand it) working on streams/error things at the moment. I worry this might conflict with them, particularly if it isn't actually doing anything useful?
There was a problem hiding this comment.
To quote the commit message: "kernel: avoid unnecessarily opening output stream"
There are three error related open PRs: #2529, #2530, #2531. None of them modifies this file. Based on the discussion last week, I am also not aware of plans by @markuspf or @ssiccha to change this function, hopefully they'll correct me on that if necessary. I am aware of more planned changes related to error handling, namely by me, see PR #2520, but there is ni conflict there either...
UPDATE: the GMP related changes cause NormalizInterface to fail. I'll revisit them later.