Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach FrattiniSubgroup methods to check for solvability #2041

Merged
merged 1 commit into from
Dec 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1241,6 +1241,9 @@ local m;
if IsTrivial(G) then
return G;
fi;
if not HasIsSolvableGroup(G) and IsSolvableGroup(G) then
return FrattiniSubgroup(G);
fi;
m := List(ConjugacyClassesMaximalSubgroups(G),C->Core(G,Representative(C)));
m := Intersection(m);
if HasIsFinite(G) and IsFinite(G) then
Expand Down
13 changes: 11 additions & 2 deletions lib/maxsub.gi
Original file line number Diff line number Diff line change
Expand Up @@ -336,13 +336,22 @@ InstallMethod( FrattiniSubgroup, "Using radical",
[ IsGroup and CanComputeFittingFree ],0,
function(G)
local m,f,i;
i:=HasIsSolvableGroup(G); # remember if the group knew about its solvability
if IsTrivial(G) then
return G;
elif Size(RadicalGroup(G))=1 then
elif IsTrivial(RadicalGroup(G)) then
return TrivialSubgroup(G);
fi;
m:=MaximalSubgroupClassesSol(G);
f:=RadicalGroup(G);

# computing the radical also determines if the group is solvable; if
# it is, and if solvability was not known before, redispatch, to give
# methods requiring solvability (e.g. for permutation groups) a chance.
if not i and IsSolvableGroup(G) then
return FrattiniSubgroup(G);
fi;

m:=MaximalSubgroupClassesSol(G);
for i in [1..Length(m)] do
if not IsSubset(m[i],f) then
f:=Core(G,NormalIntersection(f,m[i]));
Expand Down
8 changes: 8 additions & 0 deletions tst/testinstall/opers/FrattiniSubgroup.tst
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,13 @@ true
gap> HasIsNilpotentGroup(FrattiniSubgroup(p));
true

# test with a fp group which is small and solvable, which may be
# discovered by GAP as it tries to compute the Frattini subgroup.
# See issue #710.
gap> F := FreeGroup("x", "y");; x := F.1;; y := F.2;;
gap> G := F/[x*y*x^(-1)*y^(-1), x^30, (x*y)^70];;
gap> FrattiniSubgroup(G);
Group([ ])

#
gap> STOP_TEST("FrattiniSubgroup.tst", 1);