-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage of tests #1791
Reduce memory usage of tests #1791
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
==========================================
+ Coverage 61.6% 62.82% +1.22%
==========================================
Files 968 969 +1
Lines 295076 295193 +117
Branches 13049 13050 +1
==========================================
+ Hits 181774 185454 +3680
+ Misses 110522 106940 -3582
- Partials 2780 2799 +19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible. Not "elegant", of course, but pragmatic, esp. if it solves the problems @alex-konovalov is seeing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - agree with this. We need to resolve #1556 for GAP 4.9, and this will hopefully do the job.
I was also thinking of a check of package loading - what are the packages that cause the biggest expansion of the workspace.
I had a quick look at packages, and while they increase by different amounts at loading, none jumped out at me as out of proportion -- some packages are just big. I would suggest increasing the memory allowance to say 2g, I don't think that's unreasonable, and will stop tests failing. If we want to track increasing memory usage, we should do that seperately and consistently. |
I will merge this and see if this helps to #1556. Will keep in mind what you say for |
This patch unbinds variables in some tests which use a lot of memory.
I built this by running each test and measuring memory usage before and after, and unbinding in the worst ones. Long term, #1633 would fix this general problem, but that really needs some care before merging (in particular, if someone wants to figure out a better way of making a bag of local variables other than my horrible eval method).