Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make targets of the magic strings "*stdout*", "*stdin*", and "*errout*" changeable #2822

Open
ssiccha opened this issue Sep 18, 2018 · 0 comments
Open

Make targets of the magic strings "*stdout*", "*stdin*", and "*errout*" changeable #2822

ssiccha opened this issue Sep 18, 2018 · 0 comments
Assignees
@ssiccha
Labels
gapdays2018-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2018-fall kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: kernel

Comments

@ssiccha
Copy link
Contributor

ssiccha commented Sep 18, 2018 •
edited
Loading

Change the magic strings to be abstract placeholders for i/o streams, which are initialized to stdout, stdin, and errout of GAP's process. I would introduce new functions Redirect*** and Reset*** for StandardOutput, StandardInput and ErrorOut.

The Redirect*** functions should change its target permanently. I would implement RedirectStandardOutput("*errout*") to redirect "*stdout*" to wherever "*errout*" currently points to. The Reset*** functions can be used to reset the magic strings to point to stdout, stdin, and respectively errout of GAP's process again.

This was discussed in #1815 by @markuspf and @fingolfin.
@ssiccha ssiccha added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 18, 2018
@ssiccha ssiccha self-assigned this Sep 18, 2018
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level vars for stdout, stdin and errout
55a8c30 
This commit introduces new global variables StandardInput,
StandardOutput, ErrorOutput.

ADD_SET is used since the new global variables are
initialized relatively early in the start-up process,
AddSet is not yet available at this point.

The lib/colorprompt.g was changed to use StandardOutput
instead of defining its own STDOut.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
a0ddfe6 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level var ErrorOutput for '*errout*'
8ae8a26 
This commit introduces new global variables StandardInput,
StandardOutput, ErrorOutput.

ADD_SET is used since the new global variables are
initialized relatively early in the start-up process,
AddSet is not yet available at this point.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
9645f68 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
@ssiccha ssiccha mentioned this issue Sep 18, 2018
Merged
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level var ErrorOutput for '*errout*'
8b55f2f 
This commit introduces a new global variable ErrorOutput.

ADD_SET is used since the new global variables are
initialized relatively early in the start-up process,
AddSet is not yet available at this point.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
f99f240 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level var ErrorOutput for '*errout*'
82eb468 
This commit introduces a new global variable ErrorOutput.

ADD_SET is used since the new global variables are
initialized relatively early in the start-up process,
AddSet is not yet available at this point.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
0077f12 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
2efd68c 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
34a9e7e 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
ba3e5b5 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 18, 2018
@ssiccha
Adapt lib/error.g to use ErrorOutput
e04b261 
Makes all functions in error.g use ErrorOutput instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ErrorOutput.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 19, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
f08fcb5 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
@fingolfin fingolfin added the gapdays2018-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2018-fall label Sep 19, 2018
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
3d9605f 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
5912047 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
73b67a0 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
7cdf1a0 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
0ff2ba5 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
28bd1c9 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
abe600c 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 20, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
b43200f 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 21, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
0706841 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 21, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
7e11276 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 21, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
6e7187c 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Sep 21, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
7a4ede8 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
fingolfin pushed a commit that referenced this issue Sep 21, 2018
@ssiccha @fingolfin
New GAP-level var ERROR_OUTPUT for '*errout*'
a08fb33 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in #1815. See #2822.
fingolfin pushed a commit that referenced this issue Sep 21, 2018
@ssiccha @fingolfin
Adapt lib/error.g to use ERROR_OUTPUT
d49eb09 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See #2822.
markuspf pushed a commit that referenced this issue Sep 22, 2018
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
3701e18 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in #1815. See #2822.
markuspf pushed a commit that referenced this issue Sep 22, 2018
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
d11870b 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See #2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Mar 27, 2019
@ssiccha
New GAP-level var ERROR_OUTPUT for '*errout*'
633976e 
This commit introduces a new global variable ERROR_OUTPUT.

As a next step one can make it possible to change the targets
of the magic strings "*stdout*", "*stdin*", and "*errout*",
as suggested by @fingolfin in gap-system#1815. See gap-system#2822.
ssiccha added a commit to ssiccha/gap that referenced this issue Mar 27, 2019
@ssiccha
Adapt lib/error.g to use ERROR_OUTPUT
eefee04 
Makes all functions in error.g use ERROR_OUTPUT instead of the magic
string "*errout*". Then the error messages can be redirected by
overwriting ERROR_OUTPUT.

This should be temporary. If the target of "*errout*" itself can be
changed, this can be reverted again. See gap-system#2822.
@embray embray mentioned this issue Mar 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssiccha ssiccha

Labels
gapdays2018-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2018-fall kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: kernel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fingolfin @ssiccha