Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system and Travis integration #9

Closed
wants to merge 1 commit into from
Closed

Update build system and Travis integration #9

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

Travis:

  • test against GAP 4.9, 4.10, 4.11 and master
  • install zlib headers so that GAP doesn't have to compile zlib

Build system:

  • put common GAP kernel extension build rules into Makefile.gappkg

Travis:
- test against GAP 4.11 and master
- install zlib headers so that GAP doesn't have to compile zlib

PackageInfo.g:
- this used to claim compatibility with GAP >= 4.8, but actually the
  kernel extension requires GAP >= 4.11

Build system:
- put common GAP kernel extension build rules into Makefile.gappkg
@fingolfin
Copy link
Member Author

There is actually an error in the code which makes the compiler file with this message:

src/GaloisGroups.c:12:36: error: ‘i’ undeclared (first use in this function)
     pari_APPLY_same(FpXQ_pow(gel(x,i),p,T,p));

Indeed, looking into that file, I see this function (added by @videlec in commit 89dc33c):

static GEN
FpXQV_pow(GEN x, GEN T, GEN p)
{
    pari_APPLY_same(FpXQ_pow(gel(x,i),p,T,p));
}

That i is not defined, it seems?

@fingolfin
Copy link
Member Author

@videlec @markuspf do you have any hints for me how FpXQV_pow really should look like?

@fingolfin fingolfin closed this by deleting the head repository Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant