Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic simtools-run-application and improvement for setting workflows. #1379

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Feb 18, 2025

Setting of model parameters require to run one or several simtools (e.g., derivation of model parameter plus some plotting).

Plan is now:

  • setting and review of changes to model parameters is done in a separate gitlab repository
  • workflows are configured with similar yml files as we have for the integration tests. Main difference is that we allow to run separate simtools after each other.
  • stdout and stderr is captured in a log file
  • make use if the unique_id field in the model parameter json file: the product:data uuid is inserted here, which will allow to find the corresponding workflow and how this parameter has been derived.

This PR adds:

  • a simple application which reads the setting config and runs the applications specified in the config file (simtools-run-application is an application to run simtools)
  • adds various improvements to the writing of model parameters (e.g., it now allows to check if a model parameter version already exists in the DB - this way we avoid overwriting existing ones)

@GernotMaier GernotMaier self-assigned this Feb 18, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@GernotMaier GernotMaier marked this pull request as ready for review February 24, 2025 09:07

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 96.60% Coverage (94.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant