Introduce MSTx-NectarCam and MSTx-FlashCam

[GernotMaier]

This PR introduces functionality to handle design models located on several sites. This mostly required changes in the validation modules:

• allow model parameter key 'site' to be a list of sites (e.g., ['North', 'South'] instead of only one of them); requires introduction of a new version of the model_parameter meta schema (new version is 0.3.0)
• replace MSTN-design by MSTx-NectarCam and MSTS-design by MSTx-FlashCam. This requires to introduce in the list of array elements the following new entry:

  MSTx:
    collection: "telescopes"
    observatory: "CTAO"
    site: ["North", "South"]
    design_types: ["design", "test", "FlashCam", "NectarCam"]
    description: "Mid-sized telescope"

• added a new function to get the check the allowed design types: names.array_element_design_types
• note that the test for the design type is now case sensitive (as the mongoDB query is case sensitive)
• improve inconsistent testing of parameter versions and file names for parameter (testing for typically errors found during setup of the DB); this required then as a follow up to rename the model parameter json files in tests/resources to be consistent with our standards
• corresponding issue and merge request

Requires a simulation model database >0.3.0

Copilot reviewed 30 out of 45 changed files in this pull request and generated no comments.

Files not reviewed (15)

• src/simtools/layout/array_layout.py: Evaluated as low risk
• src/simtools/visualization/legend_handlers.py: Evaluated as low risk
• tests/integration_tests/config/derive_mirror_rnda_psf_random_flen.yml: Evaluated as low risk
• tests/conftest.py: Evaluated as low risk
• tests/integration_tests/config/derive_mirror_rnda_psf_no_tuning.yml: Evaluated as low risk
• tests/integration_tests/config/validate_camera_efficiency_msts.yml: Evaluated as low risk
• tests/integration_tests/config/submit_model_parameter_from_external_submit_mirror_list.yml: Evaluated as low risk
• tests/integration_tests/config/db_get_parameter_from_db_telescope_parameter_version.yml: Evaluated as low risk
• tests/integration_tests/config/validate_camera_efficiency_mstn.yml: Evaluated as low risk
• tests/integration_tests/config/derive_mirror_rnda_psf_measurement.yml: Evaluated as low risk
• src/simtools/schemas/array_elements.yml: Evaluated as low risk
• src/simtools/applications/validate_file_using_schema.py: Evaluated as low risk
• tests/integration_tests/config/db_get_parameter_from_db_array_element_position_ground.yml: Evaluated as low risk
• src/simtools/db/db_handler.py: Evaluated as low risk
• src/simtools/utils/names.py: Evaluated as low risk

[EshitaJoshi]

Thanks for the PR! I have a few minor comments.

[EshitaJoshi]

Should we also be validating the fov for FlashCam?

[GernotMaier]

Not really necessary, we are validating the 'validate_camera_fov' application and not the the FOV of all telescope types. But I see that this is not consistent with the earlier validate_camera_efficiency tests.

[ctao-dpps-sonarqube]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 100.00% Coverage (94.20% Estimated after merge)
• 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[EshitaJoshi]

Thanks for the PR!

[GernotMaier]

Thanks @EshitaJoshi for reviewing this large PR!