Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert fix to icon list item, use splitting instead #3384

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Jan 7, 2025

fixes #3382

  • The previous PR on onPaste causes the issue
    • Removing the code fixes current the issue, including other issues such as pasting always do line breaks
    • The issue in the previous PR (pasting multiple line of list only paste a single line of Icon List Item) is more about splitting.
      • This can be fixed by using supports: { splitting: true } instead, which was already done with the previous deprecation fixes
  • Testing:
    • Previous Issue: Pasting from other lists now splits. Tested with Google docs list, WordPress List block, or Stackable Icon List block ✅
    • Current Issue: Pasting now puts the cursor at the end of the line ✅
    • Additional Issue: Pasting now does not force a line break ✅

Copy link

github-actions bot commented Jan 7, 2025

🤖 Pull request artifacts

file commit
pr3384-stackable-3384-merge.zip aff96fc

github-actions bot added a commit that referenced this pull request Jan 7, 2025
@bfintal bfintal merged commit dc38e85 into develop Jan 15, 2025
1 of 6 checks passed
@bfintal bfintal deleted the fix/3382-icon-list-item branch January 15, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing issue with the Icon List block
2 participants