fix (icon popover): clear icon button should revert to the correct de…

…fault icon (#3359)
gambitph · Jan 15, 2025 · e7708f5 · e7708f5
1 parent 65740c8
commit e7708f5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/src/block-components/icon/index.js b/src/block-components/icon/index.js
@@ -62,6 +62,7 @@ export const Icon = props => {
 		attrNameTemplate = '%s',
 		hasLinearGradient = true,
 		value = '',
+		defaultValue = '',
 		onChange = NOOP,
 		openEvenIfUnselected = false,
 	} = props
@@ -177,6 +178,7 @@ export const Icon = props => {
 						}
 						setIsOpen( false )
 					} }
+					defaultValue={ defaultValue }
 				/>
 			) }
 			{ getAttribute( 'icon2' ) && (

diff --git a/src/block/icon/edit.js b/src/block/icon/edit.js
@@ -84,7 +84,7 @@ const Edit = props => {
 				className={ blockClassNames }
 			>
 				<Link linkTrigger=".stk--inner-svg">
-					<Icon />
+					<Icon defaultValue={ defaultIcon } />
 				</Link>
 			</BlockDiv>
 			{ props.isHovered && <MarginBottom /> }

diff --git a/src/components/icon-control/index.js b/src/components/icon-control/index.js
@@ -31,6 +31,7 @@ const IconControl = props => {
 			{ ...omit( props, [ 'onChange', 'value' ] ) }
 			allowReset={ true }
 			value={ props.value }
+			defaultValue={ props.defaultValue }
 			onChange={ props.onChange }
 			hasPanelModifiedIndicator={ props.hasPanelModifiedIndicator }
 		>
@@ -54,6 +55,7 @@ const IconControl = props => {
 								onClose={ onClose }
 								returnSVGValue={ props.returnSVGValue }
 								onChange={ props.onChange }
+								defaultValue={ props.defaultValue }
 							/>
 						) }
 					/>

diff --git a/src/components/icon-search-popover/index.js b/src/components/icon-search-popover/index.js
@@ -231,7 +231,7 @@ const IconSearchPopover = props => {
 					{ props.allowReset &&
 						<Button
 							onClick={ () => {
-								props.onChange( '' )
+								props.onChange( props.defaultValue || '' )
 								props.onClose()
 							} }
 							isSmall