refactored implementation

gambitph · Oct 16, 2023 · 2679739 · 2679739
1 parent feddc12
commit 2679739
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/block/tab-content/edit.js b/src/block/tab-content/edit.js
@@ -152,14 +152,14 @@ const Edit = props => {
 						if ( context[ 'stackable/tabPanelEffect' ] === 'immediate' ) {
 							if ( index !== activeTab - 1 ) {
 								return `.stk-block-tabs [data-block="${ clientId }"] {
-									${ props.attributes.equalTabHeight ? 'display:none' : 'visibility: hidden' };
+									${ props.attributes.equalTabHeight ? 'visibility: hidden' : 'display:none' };
 									z-index: 1 !important;
 								}`
 							}
 						} else { // fade
 							if ( index !== activeTab - 1 ) {
 								return `.stk-block-tabs [data-block="${ clientId }"] {
-									${ props.attributes.equalTabHeight ? 'display:none' : 'visibility: hidden' };
+									${ props.attributes.equalTabHeight ? 'visibility: hidden' : 'display:none' };
 									opacity: 0;
 									z-index: 1 !important;
 								}`

diff --git a/src/block/tab-content/style.js b/src/block/tab-content/style.js
@@ -38,8 +38,8 @@ const Styles = props => {
 				styleRule="display"
 				attrName="equalTabHeight"
 				key="equalTabHeight"
-				valueCallback={ () => {
-					return 'none'
+				valueCallback={ value => {
+					return value ? undefined : 'none'
 				} }
 				responsive="all"
 			/>