-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes compile bug for imgui v1.80 #23
Conversation
merge main branch
@RicoP - Thanks for the upgrade to 1.80. I think you forgot to update the submodule as well, maybe that's why travisCI is throwing build errors. Can you update the submodule as well? |
The .yaml is gonna need |
Thank you! I got a bit frustrated because I couldn't get it to run... Now Linux builds fine but on mac there is still the error
But I don't think that's my mistake 🤔 |
Yeah it's the Mac build running a deprecated Homebrew instaler: https://travis-ci.com/github/gallickgunner/ImGui-Addons/jobs/481090783#L88 |
Guess that would also fail on master anyway. Guess @gallickgunner can merge? |
Thanks for the info. I really don't know how to make travis-ci work and I was hesitating to merge since I didn't have any other way to check if it'd work on other platforms. So how do I go about updating the Homebrew installer? @RicoP - Yea, thanks for the contribution, merging for now since it's working on Linux. |
According to https://docs.travis-ci.com/user/installing-dependencies/#installing-packages-on-macos you could just list the packages you want installed in the YAML. |
So in essence, I need to remove the
|
And the Xcode version: #25 |
No description provided.