Add a post-install hook to restart cvmfs csi pods #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
reviewed
Mar 16, 2023
| data: | ||
| cvmfs-fix.sh: | | ||
| sleep 10; | ||
| while [ "$(kubectl get pods -n {{ .Release.Namespace }} -l 'app=cvmfscis' -l 'component=nodeplugin' -o custom-columns=STATUS:.status.phase --no-headers)" != "Running" ]; do |
There was a problem hiding this comment.
Is the app label correct? Shouldn't it be cvmfscsi instead?
Also, will this work if there are multiple nodes and get pods returns multiple lines for running pods?
There was a problem hiding this comment.
Both good catches. Should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for what's seemingly a bug in the CVMFS-CSI (see cvmfs-contrib/cvmfs-csi#70), restarting the nodeplugin pods after the chart has installed seems to fix the volume mount issue so add a post-install hook that will kill the relevant nodeplugin pods.
For the hook to work properly, must install the chart with
--waitflag.