Fix issues in the normalization of log-likelihoods in outputAnalysis classes
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relation using only active bins Removes inactive bins from the data vector and covariance matrix before evaluating the likelihood.
…minant of the covariance matrix
In the normalization of a multivariate Gaussian, there is a term $\mathrm{det}(\mathbf{\Sigma})^{-1/2}$. Previously, when evaluating log-likelihoods, this was included as $-(1/2) \mathrm{det}(\mathbf{\Sigma})$ instead of $-(1/2) \log \mathrm{det}(\mathbf{\Sigma})$. This is now corrected.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute likelihood for the scatter in the stellar mass-halo mass relation using only active bins. Specifically, removes inactive bins from the data vector and covariance matrix before evaluating the likelihood.
In the normalization of a multivariate Gaussian, there is a term$\mathrm{det}(\mathbf{\Sigma})^{-1/2}$ . Previously, when evaluating log-likelihoods, this was included as $-(1/2) \mathrm{det}(\mathbf{\Sigma})$ instead of $-(1/2) \log \mathrm{det}(\mathbf{\Sigma})$ . This is now corrected.