Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre infall evolution #749

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Fix pre infall evolution #749

merged 4 commits into from
Nov 28, 2024

Conversation

abensonca
Copy link
Collaborator

  • Do not apply pre-infall physics on the main branch;
  • Allow multiple satellite components on a branch if their orbits are equal;
  • Add a test model for pre-infall physics.

@abensonca abensonca self-assigned this Nov 28, 2024
@abensonca abensonca added bug Something isn't working subhalos satellites Relating to properties and physics of satellite halos/galaxies labels Nov 28, 2024
@github-actions GitHub Actions
Copy link

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.satellite.heating.tidal.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.satellite.mass_loss.tidal.F90'

@github-actions GitHub Actions
Copy link

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.satellite.heating.tidal.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.satellite.mass_loss.tidal.F90'

@abensonca abensonca added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit ce13376 Nov 28, 2024
291 checks passed
@abensonca abensonca deleted the fixPreInfallEvolution branch November 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@abensonca abensonca

Labels
bug Something isn't working satellites Relating to properties and physics of satellite halos/galaxies subhalos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abensonca