Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable lm claim rewards #963

Merged
merged 11 commits into from
Dec 17, 2024
Merged

feat: enable lm claim rewards #963

merged 11 commits into from
Dec 17, 2024

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented Dec 13, 2024 •
edited
Loading

As community voted to add back claiming rewards, we fulfill their wishes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Crate versions that have not been updated:

  • pallet-omnipool: v4.3.7
  • pallet-staking: v4.0.0
  • hydradx-runtime: v275.0.0

Crate versions that have been updated:

  • runtime-integration-tests: v1.25.4 -> v1.26.0
  • pallet-liquidity-mining: v4.4.3 -> v4.4.4
  • pallet-omnipool-liquidity-mining: v2.4.1 -> v2.5.0
  • pallet-xyk: v6.6.2 -> v6.6.3
  • pallet-xyk-liquidity-mining: v1.3.1 -> v1.4.0

Runtime version has not been increased.

@dmoka dmoka requested a review from martinfridrich December 13, 2024 06:39
@dmoka dmoka changed the title add: add back lm claim rewards feat: add back lm claim rewards Dec 13, 2024
martinfridrich
martinfridrich approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@martinfridrich martinfridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have time please add tests for claiming rewards to omnipool's LM

integration-tests/src/xyk_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/xyk_liquidity_mining.rs Outdated Show resolved Hide resolved
pallets/liquidity-mining/src/tests/update_global_farm.rs Outdated Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/tests/claim_rewards.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add at some tests for claiming

@mrq1911 @martinfridrich
Apply suggestions from code review
31f7e17 
Co-authored-by: martin fridrich <mrtnfridrich@gmail.com>
@mrq1911 mrq1911 changed the title feat: add back lm claim rewards feat: enable lm claim rewards Dec 16, 2024
@mrq1911
Merge branch 'master' into feat/add-back-lm-claim
86c1eba 
# Conflicts:
#	Cargo.lock
#	integration-tests/Cargo.toml
#	pallets/omnipool-liquidity-mining/Cargo.toml
#	runtime/hydradx/Cargo.toml
#	runtime/hydradx/src/lib.rs
@mrq1911
lock
e1de6ac
@mrq1911
happy c
2a1c7a0
@mrq1911 mrq1911 merged commit 71bf42b into master Dec 17, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfridrich martinfridrich martinfridrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmoka @martinfridrich @mrq1911