Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: evm permit #795

Merged
merged 48 commits into from
Apr 29, 2024
Merged

feat: evm permit #795

merged 48 commits into from
Apr 29, 2024

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

New crates:

  • pallet-evm-precompile-call-permit: v0.1.0
  • precompile-utils: v0.1.0

Crate versions that have been updated:

  • runtime-integration-tests: v1.20.3 -> v1.21.0
  • hydra-dx-math: v8.0.1 -> v8.0.2
  • pallet-asset-registry: v3.2.2 -> v3.2.3
  • pallet-bonds: v2.2.1 -> v2.2.2
  • pallet-circuit-breaker: v1.1.22 -> v1.1.23
  • pallet-dca: v1.4.4 -> v1.4.5
  • pallet-dynamic-evm-fee: v1.0.0 -> v1.0.1
  • pallet-dynamic-fees: v1.0.2 -> v1.0.3
  • pallet-ema-oracle: v1.3.0 -> v1.3.1
  • pallet-lbp: v4.7.4 -> v4.7.5
  • pallet-nft: v7.1.2 -> v7.1.3
  • pallet-omnipool: v4.1.6 -> v4.1.7
  • pallet-omnipool-liquidity-mining: v2.1.5 -> v2.1.6
  • pallet-otc: v1.1.1 -> v1.1.2
  • pallet-referrals: v1.2.3 -> v1.2.4
  • pallet-route-executor: v2.2.1 -> v2.2.2
  • pallet-stableswap: v3.5.1 -> v3.5.2
  • pallet-transaction-multi-payment: v9.6.0 -> v10.0.0
  • pallet-xcm-rate-limiter: v0.1.6 -> v0.1.7
  • hydradx-adapters: v1.3.1 -> v1.3.2
  • hydradx-runtime: v229.0.0 -> v230.0.0
  • scraper: v1.2.1 -> v1.2.2

Runtime version has been increased.

@enthusiastmartin enthusiastmartin marked this pull request as ready for review April 4, 2024 11:33
mrq1911
mrq1911 requested changes Apr 11, 2024
View reviewed changes
rococo-local/config-zombienet.json Outdated Show resolved Hide resolved
runtime/hydradx/src/evm/permit.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Show resolved Hide resolved
runtime/hydradx/src/evm/permit.rs Outdated Show resolved Hide resolved
dmoka
dmoka reviewed Apr 12, 2024
View reviewed changes
integration-tests/src/evm.rs Outdated Show resolved Hide resolved
integration-tests/src/evm.rs Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/mock.rs Show resolved Hide resolved
precompiles/call-permit/src/lib.rs Show resolved Hide resolved
precompiles/call-permit/src/tests.rs Show resolved Hide resolved
precompiles/call-permit/src/tests.rs Show resolved Hide resolved
precompiles/utils/macro/src/derive_codec.rs Show resolved Hide resolved
runtime/hydradx/src/weights/payment.rs Outdated Show resolved Hide resolved
mrq1911
mrq1911 requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happened handler implementation in transaction multipayment should set default currency same for evm accounts

runtime/hydradx/src/system.rs Outdated Show resolved Hide resolved
mrq1911
mrq1911 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for testing and UI impl

for production we need #814

@mrq1911 mrq1911 merged commit 1106ca0 into master Apr 29, 2024
4 checks passed
@enthusiastmartin enthusiastmartin deleted the feat/evm-permit branch April 29, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 mrq1911 approved these changes

@dmoka dmoka Awaiting requested review from dmoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enthusiastmartin @mrq1911 @dmoka