This repository was archived by the owner on Oct 19, 2024. It is now read-only.
fix(core): normalize signature S #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Nov 20, 2023
| @@ -324,6 +332,16 @@ mod tests { | |||
| assert_eq!(tx.recover_from().unwrap(), expected); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn can_recover_tx_sender_not_normalized() { | |||
There was a problem hiding this comment.
This is from the Anvil test removed in foundry-rs/foundry#6327 which I'll add back after this PR is merged
There was a problem hiding this comment.
mattsse
approved these changes
Nov 20, 2023
Before this patch it gets rejected as per k256 0.13.2. With this patch it succeeds again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
bluealloy/revm#870
Solution
PR Checklist