Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hidden directories scan #405

Merged
merged 9 commits into from
Jan 12, 2025
Merged

feat: hidden directories scan #405

merged 9 commits into from
Jan 12, 2025

Conversation

guyeise5
Copy link
Contributor

Adding a command line flag to extend the file scan for hidden directories.

@guyeise5
Hidden directories
ff1ab3b 
Adding a command line flag to extend the file scan for hidden directories.
@guyeise5 guyeise5 changed the title Hidden directories scan cli: hidden directories scan Dec 31, 2024
@guyeise5 guyeise5 changed the title cli: hidden directories scan feat: hidden directories scan Dec 31, 2024
gagoar
gagoar reviewed Jan 12, 2025
View reviewed changes
Copy link
Owner

@gagoar gagoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me with some tests for this? Lemme know if you can follow what I've done before

@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12737418404

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 12736779357: 0.0%
Covered Lines: 267
Relevant Lines: 267
💛 - Coveralls

@gagoar
Copy link
Owner

gagoar commented Jan 12, 2025

Hey! I appreciate your help. Some things missing so we can merge your PR!

  1. Tests. Ensure you add some test that uses the feature you are adding. It will help us keep the code compatible as we move forward.
  2. Linting, please install the lining features so that prettier does its job!
  3. Rebase with main/master. I've removed some of the engines that we were testing against (12 and 14)

I will be on the lookout for your updates.

@guyeise5 guyeise5 requested a review from gagoar January 12, 2025 21:52
@guyeise5
Copy link
Contributor Author

Could you help me with some tests for this? Lemme know if you can follow what I've done before

Added some tests

Linting, please install the lining features so that prettier does its job!

Tried, not sure I have done it correctly.

Rebase with main/master. I've removed some of the engines that we were testing against (12 and 14)

done

@gagoar

@gagoar gagoar merged commit 80d3507 into gagoar:master Jan 12, 2025
21 checks passed
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Merged
gagoar pushed a commit that referenced this pull request Jan 12, 2025
@github-actions
chore(master): release 2.5.0 (#409)
03bf4f5 
🤖 I have created a release *beep* *boop*
---


##
[2.5.0](v2.4.1...v2.5.0)
(2025-01-12)


### Features

* hidden directories scan
([#405](#405))
([80d3507](80d3507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagoar gagoar gagoar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyeise5 @coveralls @gagoar