-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ec cocos #223
fix ec cocos #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bclyons12 Can you check the COCOS here?
_cocos_signals['ec_launchers.beam.:.launching_position.phi']='?' #[ADD?]# 2.000000 # phi [rad] | ||
_cocos_signals['ec_launchers.beam.:.steering_angle_pol']='?' #[ADD?]# 2.000000 # _pol [rad] | ||
_cocos_signals['ec_launchers.beam.:.launching_position.phi']='TOR' # 2.000000 # phi [rad] | ||
_cocos_signals['ec_launchers.beam.:.steering_angle_pol']=None # 2.000000 # _pol [rad] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this odd to have no COCOS dependence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... yeah. Maybe it should be 'POL' now that you mention it. But its an angle with respect to the launcher, which confuses me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcclena the definition is: "Steering angle of the EC beam in the R,Z plane (from the -R axis towards the -Z axis), angle_pol=atan2(-k_Z,-k_R), where k_Z and k_R are the Z and R components of the mean wave vector in the EC beam". The COCOS definition for the poloidal angle is starting from the +R axis (and COCOS 11 has the polodal angle to be clockwise). This means that the steering_angle_pol
definition in IMAS is not consistent with COCOS 11. I would just leave it as None
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we merge this then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcclena What test is failing? Otherwise, I am OK to merge.
Actually, here is the error
Maybe a fluke, as |
The regression failing is strange. The issue seems to be with the GitHub CI and I would be ok to merge as is |
I see that is an option. I am OK as well. I commented on actions/setup-python#585 to try to track GitHub CI problem. |
@smithsp @orso82 With this fix, the toray regression script should pass for the
all_omas
OMFIT branch https://github.com/gafusion/OMFIT-source/pull/6454