Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/InsightsResult #663

Closed
z3nful opened this issue Sep 5, 2023 · 2 comments · Fixed by #665
Closed

Failed validation: #/definitions/InsightsResult #663

z3nful opened this issue Sep 5, 2023 · 2 comments · Fixed by #665
Labels
bug Something isn't working released

Comments

@z3nful
Copy link
Contributor

z3nful commented Sep 5, 2023

Bug Report

Using v2.4.6, I get the following validation errors from Insights:


Ticker: HIDV
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/instrumentInfo/keyTechnicals',
schemaPath: '#/properties/keyTechnicals/required',
keyword: 'required',
params: { missingProperty: 'stopLoss' },
message: "must have required property 'stopLoss'",
data: { provider: 'Trading Central' }
}
]


Ticker: MPAY
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/companySnapshot',
schemaPath: '#/definitions/InsightsCompanySnapshot/required',
keyword: 'required',
params: { missingProperty: 'sectorInfo' },
message: "must have required property 'sectorInfo'",
data: {
company: { insiderSentiments: 0.6469, earningsReports: 0.6367 },
sector: {
innovativeness: 0.5,
hiring: 0.5,
sustainability: 0.5,
insiderSentiments: 0.5,
earningsReports: 0.5,
dividends: 0.5
}
}
}
]


Ticker: RUSHA
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/reports/1/targetPriceStatus',
schemaPath: '#/definitions/InsightsReport/properties/targetPriceStatus/enum',
keyword: 'enum',
params: { allowedValues: [ 'Increased', 'Maintained', 'Decreased' ] },
message: 'must be equal to one of the allowed values',
data: '-'
},
{
instancePath: '/upsellSearchDD/researchReports',
schemaPath: '#/definitions/InsightsResearchReport/required',
keyword: 'required',
params: { missingProperty: 'investmentRating' },
message: "must have required property 'investmentRating'",
data: {
reportId: 'MS_0P000004QQ_AnalystReport_1603736082000',
provider: 'Morningstar',
title: 'Dropping Coverage of Rush Enterprises',
reportDate: 2020-10-26T18:14:42.000Z,
summary: 'Rush Enterprises is the only publicly traded, standalone commercial truck dealer in North America. With 120 locations, it sells 5.6% of new class 8 trucks as the largest truck dealer on the continent. Vehicle sales include class 4-8 new trucks as well as range of used commercial vehicles. Aftermarket parts and service are key drivers of profitability as they generate approximately 30% of revenue and 65% of gross profit. Rush’s class 8 customers include large fleets (32%), mid-size fleets (16%), vocational customers (40%), and owner-operators (12%). In 2019, Rush generated $5.8 billion in revenue.'
}
}
]

@z3nful z3nful added the bug Something isn't working label Sep 5, 2023
gadicc pushed a commit that referenced this issue Sep 6, 2023
Partially closes #663 , and closes #664.

* Fixes Insights Validation Errors
* Add missing forms for non-US companies
* schema update
* prettier
@gadicc gadicc reopened this Sep 6, 2023
@gadicc gadicc closed this as completed in 3c02753 Sep 6, 2023
gadicc pushed a commit that referenced this issue Sep 6, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

🎉 This issue has been resolved in version 2.4.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Sep 6, 2023
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

Reported and fixed with contributions from @z3nful; thanks! 🙏

gadicc pushed a commit that referenced this issue Sep 15, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
gadicc pushed a commit that referenced this issue Sep 18, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants