Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dividends fails on stocks with no historic dividends #658

Closed
PhilippS93 opened this issue Jul 27, 2023 · 2 comments
Closed

Dividends fails on stocks with no historic dividends #658

PhilippS93 opened this issue Jul 27, 2023 · 2 comments
Labels
bug Something isn't working released

Comments

@PhilippS93
Copy link

PhilippS93 commented Jul 27, 2023 •
edited
Loading

Bug Report

Describe the bug

For stocks with no historic dididends, the lib throws an error "Uncaught Error: No newlines in: Date,Dividends"

Minimal Reproduction

Call

  const dividends = (await yahooFinance.historical('TSLA', {
        period1: Date.UTC(1970, 0),
        events: "dividends",
        interval: "1d",
    }))

Tesla never paid dividends.

Environment

Node

Library version2.4.3

Additional Context
@PhilippS93 PhilippS93 added the bug Something isn't working label Jul 27, 2023
@gadicc gadicc closed this as completed in 13dcc64 Aug 12, 2023
@gadicc
Copy link
Owner

gadicc commented Aug 12, 2023

Thanks for reporting, @PhilippS93! This is fixed now and will be in the next release (there'll be an automated message here when its published).

gadicc pushed a commit that referenced this issue Aug 12, 2023
@semantic-release-bot
chore(release): 2.4.4 [skip ci]
2a2d9cc 
## [2.4.4](v2.4.3...v2.4.4) (2023-08-12)

### Bug Fixes

* **csv2json,historical:** dividends/csv with no data (fixes [#658](#658)) ([13dcc64](13dcc64))
* **deps:** update dependency node-fetch to v2.6.12 ([9f2352b](9f2352b))
* **deps:** update dependency tough-cookie to v4.1.3 ([8ea89d2](8ea89d2))
* **fixDevel:** send real request with full URL with crumb ([e3b2409](e3b2409))
* **quoteSummary:** schema: optional {stock,bond}Position (fixes [#639](#639)) ([cc669b8](cc669b8))
* **schema:** quoteSummary, secFilings types (fixes [#646](#646)) ([e92702e](e92702e))
* **search:** also "Futures" (in addition to "Future") for typeDisp ([d745b67](d745b67))
* **validateAndCoerceTypes:** add a node for #help-fix doc ([662760d](662760d))
* **validations:** quoteSummary BMW.DE (fixes [#638](#638)) ([d943e97](d943e97))
@gadicc
Copy link
Owner

gadicc commented Aug 12, 2023

🎉 This issue has been resolved in version 2.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gadicc @PhilippS93