Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Options] date queryOption should accept date not just number type #287

Closed
gadicc opened this issue Sep 9, 2021 · 6 comments
Closed

[Options] date queryOption should accept date not just number type #287

gadicc opened this issue Sep 9, 2021 · 6 comments
Labels
bug Something isn't working released

Comments

@gadicc
Copy link
Owner

gadicc commented Sep 9, 2021 •
edited
Loading

Also we should add it to the docs.
@gadicc gadicc added the bug Something isn't working label Sep 9, 2021
@gadicc gadicc added this to the v2.0 milestone Sep 9, 2021
@mikinty
Copy link
Contributor

mikinty commented Oct 9, 2021 •
edited
Loading

Hi, when do you plan to fix this? I can add it to the docs while we work on a fix out if you'd like

@mikinty mikinty mentioned this issue Oct 9, 2021
Merged
6 tasks
@glaucoheitor
Copy link
Contributor

glaucoheitor commented Dec 28, 2021 •
edited
Loading

This has been fixed as of v2.0.0.
Should this issue and the mentioned pull requests (that apparently have been merged already) be closed?

@mikinty
Copy link
Contributor

mikinty commented Dec 28, 2021

If you can link the PR then this issue can be closed

@glaucoheitor
Copy link
Contributor

Actually I was wrong, got confused with the module, I apologize.

@gadicc gadicc closed this as completed in 203b6b8 Feb 16, 2022
gadicc pushed a commit that referenced this issue Feb 16, 2022
@mikinty
chore(docs/options): how to use expiration date (#303, #287)
7598c43 
The old docs didn't mention that you could specify an expiration date. I
added in a simple example about how to do this and the number type of
the expiration date in the table.
@gadicc
Copy link
Owner Author

gadicc commented Feb 16, 2022

@mikinty thanks for your endless patience with this, I've been pretty swamped :/

This is addressed now, it can accept either a Date, number or string so it's not a breaking change anymore and will be in the next release (there'll be an automated message here when that happens).

@gadicc gadicc changed the title [Options] date queryOption should accept date not number type (breaking change) [Options] date queryOption should accept date not just number type Feb 16, 2022
@gadicc gadicc removed this from the v2.0 milestone Feb 16, 2022
gadicc pushed a commit that referenced this issue Feb 16, 2022
@semantic-release-bot
chore(release): 2.1.3 [skip ci]
59d90ba 
## [2.1.3](v2.1.2...v2.1.3) (2022-02-16)

### Bug Fixes

* **historical:** fix transform code for String date ([1e4c788](1e4c788))
* **options:** queryOpt `date` now accepts Date/string too (fixes [#287](#287)) ([203b6b8](203b6b8))

### Reverts

* Revert "chore(tests): don't use console.dir in tests" ([0480083](0480083))
* Revert "chore(tests): more debugging to figure out why tests stuck on CI" ([ba2ed67](ba2ed67))
@gadicc
Copy link
Owner Author

gadicc commented Feb 16, 2022

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gadicc @mikinty @glaucoheitor