More convention sync with cloud workstream APIs #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/tool-registry-schemas into feature/more_sync_other_cloud_apis
|
Adding @briandoconnor and @jaeddy to this since they may have more info on this service-info issue |
|
Thanks for the heads up @denis-yuen. I'm traveling for the next several days, but will take a look and add a review when I get the chance. |
coverbeck
approved these changes
May 17, 2019
openapi/ga4gh-tool-discovery.yaml
Outdated
| api_version: | ||
| type: string | ||
| description: The version of the GA4GH tool-registry API supported by this registry | ||
| example: v2 |
There was a problem hiding this comment.
Beyond the scope of this PR, but since I've never looked at this before, I'll ask here: shouldn't api_version be an array? Dockstore supports both v1 and v2.
There was a problem hiding this comment.
For background, I'm going to interpret this a bit.
I think this is the right place for minor versions in an array (e.g. 2.1, 2.2) but v1 implementations should be at an entirely different basePath
So I think I'll refine the language a bit to indicate the versions supported by the endpoints at this basePath
…/tool-registry-schemas into feature/more_sync_other_cloud_apis
briandoconnor
approved these changes
May 20, 2019
jaeddy
reviewed
May 21, 2019
| @@ -6,7 +6,7 @@ jobs: | |||
| - stage: commit-OpenAPI | |||
| install: npm i -g swagger2openapi | |||
| script: | |||
| - swagger2openapi src/main/resources/swagger/ga4gh-tool-discovery.yaml -o src/main/resources/swagger/openapi.yaml | |||
| - swagger2openapi openapi/ga4gh-tool-discovery.yaml -o openapi/openapi.yaml | |||
There was a problem hiding this comment.
Is this converting 2.0 to 3+? Just confirming.
There was a problem hiding this comment.
Yes, this is responsible for the converted OpenAPI 3 version that eventually gets checked in as commits like
ff486e2
susheel
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
LGTM
@ypriverol Do these changes work for you in Biocontainers? I hope they are not breaking, esp. the location of the swagger YAML.
garyluu
approved these changes
Jun 11, 2019
|
@ypriverol FYI, going to close for now so I can link to portions in the GA4GH approval docs. |
garyluu
added a commit
that referenced
this pull request
Feb 6, 2020
Changes from 2.0.0 + CI fix: * Explicitly define type in definitions * Change properties to snakes case and endpoints to camelcase * Move enum to its own definition * Incrementing version due to breaking changes * New endpoint and object definition to describe available files * For issues #21 and #22 * Renamed File definition to ToolFile due to swagger editor * Increment version in comment * Add more file types, better descriptions * Tool checker proposal (#26) From https://docs.google.com/document/d/1PTge27WBOKCiR2MkVSOvWKUwnFk0kx-bjq39aKRQxcY/edit?usp=sharing * Generalize the TRS to account for Singularity and Nextflow * Change toolversion's boolean indicator * Add terms of service placeholder * Install swagger2openapi * Adding operationIds (#33) See dockstore/dockstore#1210 * Moved checker to a property in Tool, also added a boolean * Specify unencoded paths are also allowed * Feature/search (#48) * Add option for search for checker workflows * For #37 , allow meta_version to be optional ga4gh/workflow-execution-service-schemas#6 ga4gh/workflow-execution-service-schemas@337cd42 * Add alias suggestion from #38 * Standardize file fields * Simplify standard (#49) * Feature/link check (#55) * Create CONTRIBUTING.md (#65) * Automatically generate docs for all branches and tags * TRS documentation update (#64) * Update openAPI3.sh * Update BasePath (#72) Updated base path to `basePath: `/ga4gh/trs/v2` * Update ga4gh-tool-discovery.yaml (#74) * Updated LICENCE Copyright (#76) * Include mention to Nextflow (#77) Mentioning nextflow as long the API is supporting workflows based on Nextflow language (NFL) https://github.com/pditommaso/tool-registry-service-schemas/blob/develop/src/main/resources/swagger/openapi.yaml#L741-L744 * Allow for more than one container image (#58) * fix type, update OpenAPI version * fix array examples * Update openapi.yaml * Rename metadata to match GA4GH PAP (#78) * Adding zenodo reference as recommended * Adding contact URL inspired by WES for PAP From security questionaire * More convention sync with cloud workstream APIs (#84) * Working on #82 also see ga4gh/workflow-execution-service-schemas#134 * Working on harmonizing with GA4GH Discovery https://github.com/ga4gh-discovery/service-info * Fix description for #85 * WS-2019-0032 WS-2019-0063 * Attempt to fix tooling (#89) * Update README.md for gitflow (#91) * Simple PRC feedback PR (#92) * Feedback from BOSC * Typo in example (#99) * Remove service-info to avoid breaking change (#101) * Move around a few fields (#97) * test gradle fix for site deployment (#105) * Optional auth (#102) * PRC feedback - strict tool versioning for reproducibility (#93) * Update to match discussion in DRS checksum object added and tweaked to match ga4gh/data-repository-service-schemas#282 * Corrects link to GA4GH . checksum hash algorithm registry (#106) * Correcting hash algorithm registry link * Correcting hash alg registry link * Fixing unrelated link * Glitchy badge (#112) * Update registry.json (#115) * Fix CI (#123) Co-authored-by: Denis Yuen <denis.yuen@oicr.on.ca> Co-authored-by: Yasset Perez-Riverol <ypriverol@gmail.com> Co-authored-by: Chris Llanwarne <cjllanwarne@users.noreply.github.com> Co-authored-by: Susheel Varma <susheel@users.noreply.github.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on