added Dockerfile #344
added Dockerfile #344
Conversation
| **TODO** | ||
| It is also possible to deploy the server using Docker. | ||
|
|
||
| - First build the Docker Image. From the server/scripts folder run:: |
There was a problem hiding this comment.
This should be 'From the deploy directory run:'
Also, can you change the :: pattern to use the code block syntax like the rest of the examples above please?
|
Works for me on Linux Mint 17.1 (I hadn't used Docker before, very impressive!). I think we'll want to refine this build process a bit over time, but this is a great start. +1 modulo tiny niggles. |
| **TODO** | ||
| It is also possible to deploy the server using Docker. | ||
|
|
||
| First build the Docker Image. From the ``deploy/scripts`` folder run: |
There was a problem hiding this comment.
Shouldn't this just be deploy?
|
Looks good @hershman. Can you fix the small bug and squash the commits please? I think we're good to merge then (unless @macieksmuga or @dcolligan have any changes they'd like to see?). |
|
Yeah, after squashing the commits and rebasing on top of the latest develop (to get rid of the Travis failure) this can be merged. |
|
Can you squash the commits and update this PR please @hershman? I think it's ready to merge... |
|
I brought @hershman's Dockerfile (with the addition of author info) into #350 as a variant and set up autobuilds. Greatly expanded the docs. Waiting for the builds to complete before I squash it. The Dockerfile in #350 supports using a local dataset rather than being restricted to the demo and is based on the Dockerfile from the mod_wsgi author |
|
I squashed down the commits - thanks for the help @jeromekelleher . |
|
Merged - thanks @hershman! |
This PR is a continuation of PR #326 which address issue #305 by adding a Dockerfile and documentation.
ACK: Just seeing docs on #337 about committing - sorry for the poorly named branch.