Look up CallSets by sample ID

[adamnovak]

Allowing search by sample ID, and reworking some comments.

[benedictpaten]

+1 though perhaps we can keep the minor formatting changes of comments to cleanup commits.

[adamnovak]

OK, I have brought this up to speed with master and pared it down to just the CallSet change: you can now look up CallSets by sample ID.

[pgrosu]

Nice! Thank you for this @adamnovak :)

[jeromekelleher]

Can you give a quick example of the use case please @adamnovak ? How does this interact semantically with the other fields in the request? Should this be unioned with null so it can be omitted?

[adamnovak]

The use case is to look up CallSets by sample ID; if you went over to the metadata API and found a sample you care about, you will need to be able to get genotype information for it.

I meant to have semantics where an empty array doesn't apply the filter; I forgot to specify that in the comment and will fix that momentarily.

[adamnovak]

OK, it now describes the proper syntax for not using this field.

[adamnovak]

Sorry, now it actually actually describes the proper syntax for not using the field; I had amended my commit without adding the file.

[jeromekelleher]

Thanks @adamnovak, +1.

[david4096]

@adamnovak can we close given #636?

Callsets can be filitered by biosampleId.