-
Notifications
You must be signed in to change notification settings - Fork 25
DUP,DEL and required positional parameters #94
Conversation
Re-opening after the 2017-05-23 Beacon workshop discussions in Hinxton. |
…o-structural_and_ranges
As per Beacon meeting Hinxton 2017-05-23
src/main/proto/ga4gh/beacon.proto
Outdated
// | ||
int64 start = 2; // required | ||
|
||
int64 start_min = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renumbering proto seems to be o.k, since proto version not in production yet.
The current As e.g. Dylan Spalding suggested, one may use sequence ontology for those types. While I support the general notion (and could see this in line with the GA4GH So I suggest to leave this at it is presented here. |
# Conflicts: # src/main/proto/ga4gh/beacon.proto
@juhtornr Great - thanks! |
This PR implements both the attributes for querying a subset of structural variants, such as currently possibly represented through the GA4GH variants schema, as well as the
start[1..2]
,end[0..2]
modifications to allow matching variants of imprecise alert, end and sequence composition.The need for these changes as well as possible ways to implement them have been discussed previously:
Also, the moving ahead with structural variant definitions in both schemas and Beacon has been discussed with the VMC team (@reece, @sarahhunt), who at the present focus on the representation of precise variants.
Technical notes:
beacon_server.proto