Fixed: outerProduct defintions and operator signatures for mat2x4 and vec4 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… E.g. outerProduct(vec2, vec4) did not succeed because the matrix return types were wrong. The computing function seemed fine. I used https://en.wikipedia.org/wiki/Outer_product as reference on what the number of columns/rows ''should'' be and fixed it so that it matches the description from wikipedia Added: tests for outerProduct with unmatched vector dimensions (actually testing all combinations now)
|
I also added a fix for the outerProduct, which did not compile anymore, because result were not matched. |
|
I just cross checked the outerProduct fixes with https://www.opengl.org/sdk/docs/man4/html/outerProduct.xhtml which handles the same definitions as wikipedia! |
Groovounet
added a commit
that referenced
this pull request
Mar 5, 2016
Fixed: outerProduct defintions and operator signatures for mat2x4 and vec4 #475
Groovounet
added a commit
that referenced
this pull request
Mar 5, 2016
|
This is merged on master branch for GLM 0.9.8 release. Thanks for contributing! |
Groovounet
added a commit
that referenced
this pull request
Mar 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sometimes causes problems when trying to refer to overloaded operators with signatures while using C++ meta programming.
I used the other classes mat4x3, mat4, ... (and vec2/vec3) as references, so these are probably the ones which do not use the intended signatures.