Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"float64 size isn't 8 bytes on this platform", can I ignore? #627

Closed
Kazade opened this issue May 2, 2017 · 5 comments
Closed

"float64 size isn't 8 bytes on this platform", can I ignore? #627

Kazade opened this issue May 2, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@Kazade
Copy link

Kazade commented May 2, 2017

I'm trying to compile a library of mine (which uses GLM) for the Sega Dreamcast, and because I'm compiling to an SH4 CPU, I hit this error here:

type_float.hpp:62:2: error: static assertion failed: float64 size isn't 8 bytes on this platform

My question is, am I OK to ignore this / comment out the assertion? Does GLM rely on this being 8 bytes elsewhere? I should be OK if I just don't use float64 right?

Thanks!

Kazade added a commit to Kazade/simulant-engine that referenced this issue May 3, 2017
@Groovounet
Copy link
Member

Hi
What compiler are you using? Does it mean there is no double on your platform? I never really consider this case... It's probably not a big deal but I guess I'll like to figure something smoother for this platform.

@Kazade
Copy link
Author

Kazade commented May 25, 2017

The compiler is GCC 4.7.3 although it's patched for the Dreamcast. I'm guessing that double is the same size as float on this platform.

@Groovounet
Copy link
Member

Can you confirm that sizeof(double) is 4 on your Dreamcast?

@Kazade
Copy link
Author

Kazade commented Jun 5, 2017

Yes confirmed. Double and float are the same size - 4 bytes (it's compiled with --m4-single-only)

@Groovounet Groovounet self-assigned this Sep 23, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Sep 23, 2017
@Groovounet
Copy link
Member

This has been implement using the define GLM_FORCE_SINGLE_ONLY.

When defined before including GLM, all requirements for 64-bits float is released.

This feature is implemented in master branch for GLM 0.9.9 release.

Thanks for reporting,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants