Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceilMultiple wrong result #412

Closed
rettenbs opened this issue Sep 22, 2015 · 2 comments
Closed

ceilMultiple wrong result #412

rettenbs opened this issue Sep 22, 2015 · 2 comments
Assignees
@Groovounet
Labels
bug
Milestone
GLM 0.9.7

Comments

@rettenbs
Copy link

The result of ceilMultiple(3.4, 0.3) is 2.7. However, I would expect it to be 3.6.

There is this line, which seems to cause the problem:

genType Tmp = Source - genType(1);

There might be a similar bug in floorMultiple (for negative values).
@rettenbs rettenbs mentioned this issue Sep 23, 2015
Merged
@rettenbs
Copy link
Author

I have created a pull request that fix this issue: #413

Groovounet added a commit that referenced this issue Sep 28, 2015
@Groovounet
Fixed GTC_round floorMultiple/ceilMultiple #412
678d393
@Groovounet Groovounet added the bug label Sep 28, 2015
@Groovounet Groovounet added this to the GLM 0.9.7 milestone Sep 28, 2015
@Groovounet Groovounet self-assigned this Sep 28, 2015
@Groovounet
Copy link
Member

Thanks for submitting a pull request!

Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
bug
Projects
None yet
Milestone
GLM 0.9.7
Development

No branches or pull requests
2 participants
@Groovounet @rettenbs