Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on Windows #30

Closed
g-andrade opened this issue Aug 29, 2021 · 1 comment
Closed

Run CI on Windows #30

g-andrade opened this issue Aug 29, 2021 · 1 comment

Comments

@g-andrade
Copy link
Owner

g-andrade commented Aug 29, 2021

Tentatively introduced in fcdd530, reverted in 9e39953 due to Elvis complaining about trailing spaces and operator spaces all over the place:

Screenshot at 2021-08-30 00-43-58

My first guess is that either git or something else is injecting \r into the source files and that is causing Elvis to misdetect the extra whitespaces as trailing (but I didn't confirm this in any way.)

g-andrade added a commit that referenced this issue Aug 30, 2021
This time we'll try our fix to `elvis_core`.

Hopefully we'll confirm that it would fix the following:
* #30
g-andrade added a commit that referenced this issue Aug 30, 2021
This time we'll try our fix to `elvis_core`.

Hopefully we'll confirm that it would fix the following:
* #30
g-andrade added a commit that referenced this issue Aug 30, 2021
Resolves:
* #30

(Hopefully)
@g-andrade
Copy link
Owner Author

Great success!

Perhaps not permanent, depending on what direction is taken relative to the underlying issue - I'll just use my fork of elvis_core for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant